You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2024/09/19 23:22:08 UTC
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21827
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
IMPALA-13393: Remove old javax.el config
Pinning javax.el was done when Impala still used Sentry. That was
removed in IMPALA-9708, and Hbase no longer depends on javax.el. So this
pin is no longer relevant.
Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
---
M java/pom.xml
1 file changed, 0 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/21827/1
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
IMPALA-13393: Remove old javax.el config
Pinning javax.el was done when Impala still used Sentry. That was
removed in IMPALA-9708, and Hbase now explicitly depends on a
specific version. So this pin is no longer relevant.
Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Reviewed-on: http://gerrit.cloudera.org:8080/21827
Tested-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Riza Suminto <ri...@cloudera.com>
---
M java/pom.xml
1 file changed, 0 insertions(+), 31 deletions(-)
Approvals:
Michael Smith: Verified
Riza Suminto: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG@10
PS2, Line 10: Hbase now explicitly depends on a
> I guess this isn't true for either of them. They both explicitly specify a
Ack
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 23:32:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 3: Verified+1
Carry Verified +1 for commit message update.
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 22:26:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16983/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 23:55:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11029/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 16:51:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21827
to look at the new patch set (#3).
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
IMPALA-13393: Remove old javax.el config
Pinning javax.el was done when Impala still used Sentry. That was
removed in IMPALA-9708, and Hbase now explicitly depends on a
specific version. So this pin is no longer relevant.
Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
---
M java/pom.xml
1 file changed, 0 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/21827/3
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 21:47:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG@10
PS2, Line 10: Hbase no longer depends on javax.el
Is this true for both APACHE_HBASE_VERSION=2.6.0 and CDP_HBASE_VERSION=2.4.17.7.3.0.0-128 ?
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 22:07:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13393: Remove old javax.el config
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21827 )
Change subject: IMPALA-13393: Remove old javax.el config
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21827/2//COMMIT_MSG@10
PS2, Line 10: Hbase no longer depends on javax.el
> Is this true for both APACHE_HBASE_VERSION=2.6.0 and CDP_HBASE_VERSION=2.4.
I guess this isn't true for either of them. They both explicitly specify a javax.el version. I'll update the commit message, but I think removing the explicit versioning still makes sense for Impala.
--
To view, visit http://gerrit.cloudera.org:8080/21827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5be3eeeacf2f6fb04bc5106902e1d11b3886d844
Gerrit-Change-Number: 21827
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 22:25:23 +0000
Gerrit-HasComments: Yes