[jira] [Created] (PDFBOX-2068) Add filter parameter to PDImageXObject(document, filteredStream) constructor

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

Tilman Hausherr created PDFBOX-2068:
---------------------------------------

             Summary: Add filter parameter to PDImageXObject(document, filteredStream) constructor 
                 Key: PDFBOX-2068
                 URL: https://issues.apache.org/jira/browse/PDFBOX-2068
             Project: PDFBox
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Tilman Hausherr
            Assignee: Tilman Hausherr
            Priority: Minor
             Fix For: 2.0.0


I am adding a third parameter to
{code}
public PDImageXObject(PDDocument document, InputStream filteredStream)
{code}
i.e. changing it to
{code}
public PDImageXObject(PDDocument document, InputStream filteredStream, COSBase cosFilter)
{code}
because in the code, the filter is always set afterwards. My change improves code clarity. The caller _knows_ what filter was used because he used it to prepare the filteredStream content.

WDYT about also adding width, height, bpc and colorspace to that constructor? These four paramaters are always used.

This cool guy (enter his name on youtube) has arguments to use constructors parameters instead of setters:
http://misko.hevery.com/2009/02/19/constructor-injection-vs-setter-injection/

IMHO, mixing constructor initialization and setter initialization looks confusing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)