You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/03/01 02:03:55 UTC
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12640
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
IMPALA-7988: addendum: tolerate docker stop failure
"docker stop" may fail if the container has not started.
This bug prevented using the dockerised minicluster.
Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
---
M bin/start-impala-cluster.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/12640/1
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3877/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 21:16:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py@471
PS1, Line 471: check_call(["docker", "stop", container_name])
> On second thought, this one might never fail, because we are iterating over
Yeah that was my thought. It could possibly race with the container being stopped (or exiting) in the background but I don't think that's a serious concern.
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:23:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:32:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2313/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 02:45:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3868/
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 03:48:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
IMPALA-7988: addendum: tolerate docker stop failure
"docker stop" may fail if the container has not started.
This bug prevented using the dockerised minicluster.
Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Reviewed-on: http://gerrit.cloudera.org:8080/12640
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/start-impala-cluster.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3868/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:32:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 21:16:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 1: Code-Review+2
Makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:28:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 18:44:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3883/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 18:44:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py@471
PS1, Line 471: check_call(["docker", "stop", container_name])
> This is another docker stop location.
On second thought, this one might never fail, because we are iterating over running containers.
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:14:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 05:58:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3886/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 01:36:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3877/
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 01:18:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py@471
PS1, Line 471: check_call(["docker", "stop", container_name])
This is another docker stop location.
--
To view, visit http://gerrit.cloudera.org:8080/12640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:07:30 +0000
Gerrit-HasComments: Yes