You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Sidney Markowitz <si...@sidney.com> on 2022/05/01 01:37:55 UTC
Problems in make test
I messed up with make test during the release candidate process.
I hope that I just have my setup wrong, because I expect this would have
been mentioned before now if everyone gets it.
In trunk, or equivalently 4.0.0-rc1, with a clean environment,
perl Makefile.PL
make
make test
results in many tests failing after issuing warnings with
config: registryboundaries: no tlds defined, need to run sa-update
I don't see the same problem doing the same thing in the same
environment with the 3.4.6 distribution.
Is it just me or does a bug have to be opened?
-- Sidney
Re: Problems in make test
Posted by gi...@paclan.it.
On 5/1/22 07:47, Sidney Markowitz wrote:
> Kevin A. McGrail wrote on 1/05/22 3:47 pm:
>> A) When was that MANIFEST change because I do believe there are a couple
>> of items that should be included. I think it's used with ruleqa or
>> something.
>
> r1880742 | gbechis | 2020-08-11 02:29:41 +1200 (Tue, 11 Aug 2020) | 2 lines
> Changed paths:
> M /spamassassin/trunk/MANIFEST
>
> remove rules from MANIFEST that should be downloaded using sa-update
>
This was just a partial revert of the lines I added to MANIFEST in r1878925
>>
>> B) do any rc's pass make test without a symlink to a trunk checkout to
>> get the rules rulessrc and t.rules?
>
> The rest of my followup on this is now in comments in bug 7982, will continue there.
Let's continue there.
Giovanni
Re: Problems in make test
Posted by Sidney Markowitz <si...@sidney.com>.
Kevin A. McGrail wrote on 1/05/22 3:47 pm:
> A) When was that MANIFEST change because I do believe there are a couple
> of items that should be included. I think it's used with ruleqa or
> something.
r1880742 | gbechis | 2020-08-11 02:29:41 +1200 (Tue, 11 Aug 2020) | 2 lines
Changed paths:
M /spamassassin/trunk/MANIFEST
remove rules from MANIFEST that should be downloaded using sa-update
>
> B) do any rc's pass make test without a symlink to a trunk checkout to
> get the rules rulessrc and t.rules?
The rest of my followup on this is now in comments in bug 7982, will
continue there.
Re: Problems in make test
Posted by "Kevin A. McGrail" <km...@apache.org>.
A) When was that MANIFEST change because I do believe there are a couple
of items that should be included. I think it's used with ruleqa or
something.
B) do any rc's pass make test without a symlink to a trunk checkout to
get the rules rulessrc and t.rules?
On 4/30/2022 11:34 PM, Sidney Markowitz wrote:
> The instructions in build/README say to only link when doing it in a
> branch. I did track the problem down to a commit that removed
> 20_aux_tlds.cf from MANIFEST along with another rules file, saying it
> should come from sa-update. Even if I put them back, there are still
> other tests breaking that seem to require one or more rules files that
> never were in MANIFEST. This seems to be a new problem in 4.0 that
> only shows up when running make test from a distribution tarball, not
> from a trunk svn checkout, and so wasn't noticed until now. We can
> continue this in the new bug comments.
--
Kevin A. McGrail
KMcGrail@Apache.org
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: Problems in make test
Posted by Sidney Markowitz <si...@sidney.com>.
The instructions in build/README say to only link when doing it in a
branch. I did track the problem down to a commit that removed
20_aux_tlds.cf from MANIFEST along with another rules file, saying it
should come from sa-update. Even if I put them back, there are still
other tests breaking that seem to require one or more rules files that
never were in MANIFEST. This seems to be a new problem in 4.0 that only
shows up when running make test from a distribution tarball, not from a
trunk svn checkout, and so wasn't noticed until now. We can continue
this in the new bug comments.
Kevin A. McGrail wrote on 1/05/22 2:31 pm:
> I don't know if you can run a make test on an rc release without doing
> an ln -s to the rules dir in an svn checkout. If you follow the steps
> in the build/README file, and there are like three ln -s commands that
> might help.
>
Re: Problems in make test
Posted by "Kevin A. McGrail" <km...@apache.org>.
On 4/30/2022 10:08 PM, Sidney Markowitz wrote:
> Do you mean 20_aux_tlds.cf? I did install SpamAssassin on the box and
> ran sa-update. The file is in
> /var/lib/spamassassin/4.000000/updates_spamassassin_org/20_aux_tlds.cf
>
> The file is not in the 4_0_0_rc_1 tar. If I run make test in the svn
> checkout, where the file is in the rules directory, that runs fine.
>
> How is make test supposed to find 20_aux_tlds.cf when not run from a
> full svn checkout?
I don't know if you can run a make test on an rc release without doing
an ln -s to the rules dir in an svn checkout. If you follow the steps
in the build/README file, and there are like three ln -s commands that
might help.
Re: Problems in make test
Posted by Sidney Markowitz <si...@sidney.com>.
Do you mean 20_aux_tlds.cf? I did install SpamAssassin on the box and
ran sa-update. The file is in
/var/lib/spamassassin/4.000000/updates_spamassassin_org/20_aux_tlds.cf
The file is not in the 4_0_0_rc_1 tar. If I run make test in the svn
checkout, where the file is in the rules directory, that runs fine.
How is make test supposed to find 20_aux_tlds.cf when not run from a
full svn checkout?
Kevin A. McGrail wrote on 1/05/22 1:39 pm:
> Sidney, do you have SA rules installed on the box? Might be a chicken/egg
> issue but sounds like you don't have the 20 TLD files. -KAM
> --
> Kevin A. McGrail
> Member, Apache Software Foundation
> Chair Emeritus Apache SpamAssassin Project
> https://www.linkedin.com/in/kmcgrail - 703.798.0171
>
>
> On Sat, Apr 30, 2022 at 9:38 PM Sidney Markowitz <si...@sidney.com> wrote:
>
>> I messed up with make test during the release candidate process.
>>
>> I hope that I just have my setup wrong, because I expect this would have
>> been mentioned before now if everyone gets it.
>>
>> In trunk, or equivalently 4.0.0-rc1, with a clean environment,
>>
>> perl Makefile.PL
>> make
>> make test
>>
>> results in many tests failing after issuing warnings with
>>
>> config: registryboundaries: no tlds defined, need to run sa-update
>>
>> I don't see the same problem doing the same thing in the same
>> environment with the 3.4.6 distribution.
>>
>> Is it just me or does a bug have to be opened?
>>
>> -- Sidney
>>
>>
>
Re: Problems in make test
Posted by "Kevin A. McGrail" <km...@apache.org>.
Sidney, do you have SA rules installed on the box? Might be a chicken/egg
issue but sounds like you don't have the 20 TLD files. -KAM
--
Kevin A. McGrail
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
On Sat, Apr 30, 2022 at 9:38 PM Sidney Markowitz <si...@sidney.com> wrote:
> I messed up with make test during the release candidate process.
>
> I hope that I just have my setup wrong, because I expect this would have
> been mentioned before now if everyone gets it.
>
> In trunk, or equivalently 4.0.0-rc1, with a clean environment,
>
> perl Makefile.PL
> make
> make test
>
> results in many tests failing after issuing warnings with
>
> config: registryboundaries: no tlds defined, need to run sa-update
>
> I don't see the same problem doing the same thing in the same
> environment with the 3.4.6 distribution.
>
> Is it just me or does a bug have to be opened?
>
> -- Sidney
>
>