[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5802: Add Per-DS HTTP/2 and TLS Versions Support

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #5802:
URL: https://github.com/apache/trafficcontrol/pull/5802#discussion_r625899091



##########
File path: CHANGELOG.md
##########
@@ -36,6 +36,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Added integration to use ACME to generate new SSL certificates.
 - Add a Federation to the Ansible Dataset Loader
 - Added asynchronous status to ACME certificate generation.
+- Added per Delivery Service HTTP/2 and TLS Versions support, via ssl_server_name.yaml and sni.yaml. See overview/profiles_and_parameters and t3c docs.

Review comment:
       `See overview/profiles_and_parameters` is no longer accurate

##########
File path: docs/source/overview/delivery_services.rst
##########
@@ -1023,3 +1023,20 @@ A text-based unique identifier for a Delivery Service. Many :ref:`to-api` endpoi
 .. [#cardinality] In source code and :ref:`to-api` responses, the "Long Description" fields of a Delivery Service are "0-indexed" - hence the names differing slightly from the ones displayed in user-friendly UIs.
 .. [#dupOrigin] These Delivery Services Types are vulnerable to what this writer likes to call the "Duplicate Origin Problem". This problem is tracked by :issue:`3537`.
 .. [#httpOnlyRegex] These regular expression types can only appear in the Match List of HTTP-:ref:`Routed <ds-types>` Delivery Services.
+
+
+Parameters
+----------------------

Review comment:
       nit: number of dashes should match the length of the header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org