You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/05 14:24:41 UTC
[GitHub] [incubator-superset] paulvic opened a new pull request #8506: [WIP]
Allow customization of the browser local storage usage threshold
paulvic opened a new pull request #8506: [WIP] Allow customization of the browser local storage usage threshold
URL: https://github.com/apache/incubator-superset/pull/8506
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This change allows customization of the threshold for when the browser local storage usage notification appears.
The default setting is that the notification appears when 90% of 5MB local storage is used but in our deployment some users are seeing this warning regularly despite the browser being fully responsive so we'd like to be able to tweak the threshold.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The notification looks like this:
### TEST PLAN
- Validated the the override works as expected and that it falls back to the original values when no override is specified.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org