[GitHub] [pulsar] MarvinCai commented on a change in pull request #12047: [Issue 12046][Broker] Check WebServicePortTls and BrokerServicePorts when tlsEnabled

[GitBox <gi...@apache.org>]

MarvinCai commented on a change in pull request #12047:
URL: https://github.com/apache/pulsar/pull/12047#discussion_r714053483



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -610,6 +610,11 @@ public void start() throws PulsarServerException {
                 throw new IllegalArgumentException("brokerServicePort/brokerServicePortTls must be present");
             }
 
+            if (config.isTlsEnabled()
+                    && (!config.getWebServicePortTls().isPresent() || !config.getBrokerServicePortTls().isPresent())){
+                throw new IllegalArgumentException("webServicePortTls/brokerServicePortTls must be present");

Review comment:
       nit: the error message can be more informative like `webServicePortTls/brokerServicePortTls must be set when TlsEnabled set to true`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org