You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Krishnan Chandra <kr...@optimizely.com> on 2015/09/24 11:23:23 UTC

Re: Review Request 38706: [FLUME-2599, FLUME-2610] Removing usage of CounterGroup from legacy sources

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38706/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 9:23 a.m.)


Review request for Flume.


Summary (updated)
-----------------

[FLUME-2599, FLUME-2610] Removing usage of CounterGroup from legacy sources


Bugs: FLUME-2599 and FLUME-2610
    https://issues.apache.org/jira/browse/FLUME-2599
    https://issues.apache.org/jira/browse/FLUME-2610


Repository: flume-git


Description
-------

This change will remove the use of the default CounterGroup from legacy sources (Avro + Thrift) and switch over to using the more robust MonitoredCounterGroup.


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java 44e26e4 
  flume-ng-core/src/main/java/org/apache/flume/instrumentation/RPCCounter.java PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/instrumentation/RPCCounterMBean.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java b1f637f 
  flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java dde8f28 
  flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java 47913dc 

Diff: https://reviews.apache.org/r/38706/diff/


Testing
-------

Unit tests included


Thanks,

Krishnan Chandra