You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (Created) (JIRA)" <ji...@apache.org> on 2011/10/28 20:27:32 UTC

[jira] [Created] (AVRO-948) Thrift: non-numeric fields should be nullable

Thrift: non-numeric fields should be nullable
---------------------------------------------

                 Key: AVRO-948
                 URL: https://issues.apache.org/jira/browse/AVRO-948
             Project: Avro
          Issue Type: Bug
          Components: java
            Reporter: Doug Cutting
             Fix For: 1.6.0


In Thrift, struct fields with non-numeric value types should be nullable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-948) Thrift: non-numeric fields should be nullable

Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-948:
------------------------------

    Assignee: Doug Cutting
      Status: Patch Available  (was: Open)
    
> Thrift: non-numeric fields should be nullable
> ---------------------------------------------
>
>                 Key: AVRO-948
>                 URL: https://issues.apache.org/jira/browse/AVRO-948
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.6.0
>
>         Attachments: AVRO-948.patch
>
>
> In Thrift, struct fields with non-numeric value types should be nullable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-948) Thrift: non-numeric fields should be nullable

Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-948:
------------------------------

    Attachment: AVRO-948.patch

Here's an improved patch that also correctly handles numeric fields that are declared optional.
                
> Thrift: non-numeric fields should be nullable
> ---------------------------------------------
>
>                 Key: AVRO-948
>                 URL: https://issues.apache.org/jira/browse/AVRO-948
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.6.0
>
>         Attachments: AVRO-948.patch, AVRO-948.patch
>
>
> In Thrift, struct fields with non-numeric value types should be nullable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-948) Thrift: non-numeric fields should be nullable

Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-948:
------------------------------

    Attachment: AVRO-948.patch

Here's a patch that makes non-numeric fields nullable, to be consistent with Thrift semantics.  It also identified bugs when embedding enum and binary values in unions, also fixed here.
                
> Thrift: non-numeric fields should be nullable
> ---------------------------------------------
>
>                 Key: AVRO-948
>                 URL: https://issues.apache.org/jira/browse/AVRO-948
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>             Fix For: 1.6.0
>
>         Attachments: AVRO-948.patch
>
>
> In Thrift, struct fields with non-numeric value types should be nullable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-948) Thrift: non-numeric fields should be nullable

Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-948:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I committed this.
                
> Thrift: non-numeric fields should be nullable
> ---------------------------------------------
>
>                 Key: AVRO-948
>                 URL: https://issues.apache.org/jira/browse/AVRO-948
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.6.0
>
>         Attachments: AVRO-948.patch, AVRO-948.patch
>
>
> In Thrift, struct fields with non-numeric value types should be nullable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira