[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #148: [Log Improvement] Output the registering/lost/exclude nodes in log

[GitBox <gi...@apache.org>]

zuston commented on code in PR #148:
URL: https://github.com/apache/incubator-uniffle/pull/148#discussion_r941335000


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -99,6 +101,13 @@ void nodesCheck() {
           }
         }
       }
+      if (!deleteIds.isEmpty() || outputAliveServerCount % 30 == 0) {
+        LOG.info("Alive servers number: {}, ids: {}",

Review Comment:
   Number is not enough. I want to know which servers are lost from the coordinator side. 
   
   And the number shown in log will be easy to find.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org