You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2003/12/23 18:55:39 UTC
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator SingleSignOn.java
markt 2003/12/23 09:55:39
Modified: catalina/src/share/org/apache/catalina/authenticator
SingleSignOn.java
Log:
- Fix bug 10372. Prevent NPE if container is null
- Port of functionality from TC5 implemented by bobh.
Revision Changes Path
1.12 +8 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java
Index: SingleSignOn.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator/SingleSignOn.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- SingleSignOn.java 9 Jun 2002 02:19:41 -0000 1.11
+++ SingleSignOn.java 23 Dec 2003 17:55:39 -0000 1.12
@@ -411,7 +411,10 @@
public String toString() {
StringBuffer sb = new StringBuffer("SingleSignOn[");
- sb.append(container.getName());
+ if (container == null )
+ sb.append("Container is null");
+ else
+ sb.append(container.getName());
sb.append("]");
return (sb.toString());
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit:
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/authenticator
SingleSignOn.java
Posted by Brian Stansberry <br...@wanconcepts.com>.
Hi,
At 05:55 PM 12/23/2003 +0000, you wrote:
>markt 2003/12/23 09:55:39
>
> Modified: catalina/src/share/org/apache/catalina/authenticator
> SingleSignOn.java
> Log:
> - Fix bug 10372. Prevent NPE if container is null
> - Port of functionality from TC5 implemented by bobh.
A couple weeks back I posted to bugzilla (bug 23881) a patch to TC 4.1 that deals with a bunch of SSO issues (bugs 4350, 9077, 10040 and 23881). The patch was a port of the patch that was applied to the TC5 branch.
That patch also had the above NPE fix in it.
I was wondering if there was any interest in committing that patch to TC 4.1 before the next release. If there is, I'll update it so it doesn't conflict with what Mark just committed (and anything else committed since I posted it). If there's no interest, I'll go Christmas shopping instead ;-)
>Best,
Brian Stansberry
WAN Concepts, Inc.
www.wanconcepts.com
Tel: (510) 894-0114 x 116
Fax: (510) 797-3005
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org