You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 23:14:30 UTC
[GitHub] [spark] xkrogen opened a new pull request #34084: SPARK-35672 Handle environment variable replacement in user classpath lists
xkrogen opened a new pull request #34084:
URL: https://github.com/apache/spark/pull/34084
### What changes were proposed in this pull request?
Add environment variable resolution logic to `yarn.Client.getUserClasspathUrls`, which allows for users to specify JAR paths (e.g. from `spark.jars`) which contain references to environment variables.
This is a best-effort attempt to mimic the variable resolution logic used by a typical shell (implemented in `yarn.Client.replaceEnvVars`).
### Why are the changes needed?
In PR #32810 the way user JAR classpaths were passed around was changed to avoid passing them via the command line, which is prone to exceeding maximum argument length limitations. However, as a result, the classpaths are no longer interpreted by the shell, so environment variables are not resolved. This is explicitly called out in the docs of `spark.yarn.config.gatewayPath` as a use case, so we definitely need to continue supporting it. There are more details in the comments of SPARK-36572.
### Does this PR introduce _any_ user-facing change?
Yes, using environment variables in `spark.jars` or `spark.yarn.config.replacementPath` will work again, as it did before PR #32810.
### How was this patch tested?
New unit tests added for this specific case in `YarnClusterSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926263087
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48081/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926269626
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48081/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230858
**[Test build #143572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143572/testReport)** for PR 34084 at commit [`e36814b`](https://github.com/apache/spark/commit/e36814b831c2a0fd33725bc7d6a704e8b347025b).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-930193085
this can be closed since we have https://github.com/apache/spark/pull/34120, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230014
**[Test build #143572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143572/testReport)** for PR 34084 at commit [`e36814b`](https://github.com/apache/spark/commit/e36814b831c2a0fd33725bc7d6a704e8b347025b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926238220
**[Test build #143573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143573/testReport)** for PR 34084 at commit [`341a2d3`](https://github.com/apache/spark/commit/341a2d31dab85af10208cf9a8947b062ddb05a34).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen edited a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen edited a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230650
@peter-toth @tgravescs @mridulm FYI
It's not super clean to have to perform the variable resolution in Spark code, and in particular one aspect I left out is handling of escaping, so you can't use e.g. `/home/\$usr/` to actually refer to the path `/home/$usr` -- `usr` will be resolved as a variable. Similarly on Windows, `\Home\%%usr\` wouldn't work as expected, resolving to `\Home\usr` instead of `\Home\%usr`. Handling the escapes is a lot trickier than just doing variable substitution and I'm not sure it would be a good idea to try to handle it via simple regexes as I'm doing for the substitution now. But I think the current logic should cover real-world use cases. Open to other ideas here, though. One option would be to spin up an external shell process to do the resolution, but it seems messy and could be quite slow for large lists.
The other approach would be to hide this behind a feature flag, but it's kind of a weird feature flag. "Turn on scalable user JAR handling to bypass argument length limits, but also turn off environment variable substitution." I think it will be confusing for users so I'd prefer to avoid it if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-930309394
Yes, thanks for the reminder @tgravescs !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230895
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-930193085
this can be closed since we have https://github.com/apache/spark/pull/34120, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926246809
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48081/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230895
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143572/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230014
**[Test build #143572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143572/testReport)** for PR 34084 at commit [`e36814b`](https://github.com/apache/spark/commit/e36814b831c2a0fd33725bc7d6a704e8b347025b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926237110
**[Test build #143573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143573/testReport)** for PR 34084 at commit [`341a2d3`](https://github.com/apache/spark/commit/341a2d31dab85af10208cf9a8947b062ddb05a34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926271605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926230650
@peter-toth @tgravescs @mridulm FYI
It's not super clean to have to perform the variable resolution in Spark code, and in particular one aspect I left out is handling of escaping, so you can't use e.g. `/home/\$usr/` to actually refer to the path `/home/$usr` -- `usr` will be resolved as a variable. Similarly on Windows, `\Home\%%usr\` wouldn't work as expected, resolving to `\Home\usr` instead of `\Home\%usr`. Handling the escapes is a lot trickier than just doing variable substitution and I'm not sure it would be a good idea to try to handle it via simple regexes as I'm doing for the substitution now. But I think the current logic should cover real-world use cases. Open to other ideas here, though.
The other approach would be to hide this behind a feature flag, but it's kind of a weird feature flag. "Turn on scalable user JAR handling to bypass argument length limits, but also turn off environment variable substitution." I think it will be confusing for users so I'd prefer to avoid it if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926271574
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926271605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen closed pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen closed pull request #34084:
URL: https://github.com/apache/spark/pull/34084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926269626
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48081/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926237110
**[Test build #143573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143573/testReport)** for PR 34084 at commit [`341a2d3`](https://github.com/apache/spark/commit/341a2d31dab85af10208cf9a8947b062ddb05a34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926238246
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143573/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926251925
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-926238246
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143573/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen closed pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen closed pull request #34084:
URL: https://github.com/apache/spark/pull/34084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34084: [SPARK-35672][CORE][YARN] Handle environment variable replacement in user classpath lists
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34084:
URL: https://github.com/apache/spark/pull/34084#issuecomment-930309394
Yes, thanks for the reminder @tgravescs !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org