[jira] [Commented] (LOG4J2-2676) Backport PluginProcessor use of javax.annotation.processing.Messager to 2.12.x/2.13

["Ralph Goers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909857#comment-16909857 ] 

Ralph Goers commented on LOG4J2-2676:
-------------------------------------

I made those changes in support of LOG4J2-2621 which moved the plugin processor to its own maven module and changed the processor to generate a Java source file instead of a data file. That source file gets compiled as part of your application and is then loaded by the service loader. To be honest, I don't remember why I converted those System.outs to messager.printMessage - probably because I just noticed they were there and writing to stdout directly is usually the wrong thing to do.

Log4j 2.12.2 would be targeted at bug fixes only that are applicable to Java 7. Right now we don't have anything targeted at that.  Log4j 2.13.0 will require Java 8. If you are OK with Java 8 I could changes just the system.out calls on the release-2.x branch. However, Log4j 2.12.1 was just released and I am not planning on doing another release build for at least a month as I will be leaving on vacation in a week.

> Backport PluginProcessor use of javax.annotation.processing.Messager to 2.12.x/2.13
> -----------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2676
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2676
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Plugins
>    Affects Versions: 2.12.1
>            Reporter: Gregg Donovan
>            Priority: Minor
>             Fix For: 2.13.0
>
>
> PluginProcessor, as of 2.12.1, writes status messages to System.out. This breaks using the Log4J annotation processor with Bazel, as it expects those messages to be sent to javax.annotation.processing.Messager. PluginProcessor on master uses Messager. This ticket is to track backporting just that change to either 2.12.2 or 2.13.0, whatever makes the most sense.
> See [this discussion|https://lists.apache.org/thread.html/26501473dc123ba907880a6e5baf51cde45311652c3a8beec714d9fb@%3Clog4j-user.logging.apache.org%3E] on the mailing list for more context.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)