[GitHub] [solr] dsmiley commented on a diff in pull request #983: SOLR-16353: SplitShardCmd.checkDiskSpace can fail for transient core

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #983:
URL: https://github.com/apache/solr/pull/983#discussion_r956882802


##########
solr/solr-ref-guide/modules/deployment-guide/pages/solr-on-hdfs.adoc:
##########
@@ -246,6 +246,17 @@ s|Required |Default: none
 +
 The Kerberos principal that Solr should use to authenticate to secure Hadoop; the format of a typical Kerberos V5 principal is: `primary/instance@realm`.
 
+== Shard splitting settings

Review Comment:
   The *only* point of putting this documentation here, on the Hdfs page, would be **if** we would recommend the user to do something about this setting if they are using Hdfs.  But you flipped this setting off for HdfsDirectory and so I think it's now misplaced.  Instead, I'd specify this over in a shard split page.
   
   And when yhou do, ensure it's clear that this is a *system property*; not a parameter or something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org