[GitHub] [beam] twang126 commented on a diff in pull request #28513: Report total active threads

["twang126 (via GitHub)" <gi...@apache.org>]

twang126 commented on code in PR #28513:
URL: https://github.com/apache/beam/pull/28513#discussion_r1329392726


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -255,7 +256,6 @@ private static MapTask parseMapTask(String input) throws IOException {
 
   public static void main(String[] args) throws Exception {
     JvmInitializers.runOnStartup();
-

Review Comment:
   nit: undo



##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2277,7 +2288,8 @@ public void completeWork(ShardedKey shardedKey, long workToken) {
         if (completedWork.getWorkItem().getWorkToken() != workToken) {
           // Work may have been completed due to clearing of stuck commits.
           LOG.warn(
-              "Unable to complete due to token mismatch for key {} and token {}, actual token was {}.",

Review Comment:
   nit: undo this change



##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -158,6 +158,7 @@ public class StreamingDataflowWorker {
 
   /** The idGenerator to generate unique id globally. */
   private static final IdGenerator idGenerator = IdGenerators.decrementingLongs();
+

Review Comment:
   nit: undo 



##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2356,7 +2368,8 @@ public void printActiveWork(PrintWriter writer) {
           "<table border=\"1\" "
               + "style=\"border-collapse:collapse;padding:5px;border-spacing:5px;border:1px\">");
       writer.println(
-          "<tr><th>Key</th><th>Token</th><th>Queued</th><th>Active For</th><th>State</th><th>State Active For</th></tr>");
+          "<tr><th>Key</th><th>Token</th><th>Queued</th><th>Active For</th><th>State</th><th>State"

Review Comment:
   nit: undo



##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -996,7 +1003,7 @@ private void dispatchLoop() {
               inputDataWatermark,
               synchronizedProcessingTime,
               workItem,
-              /*getWorkStreamLatencies=*/ Collections.emptyList());
+              /* getWorkStreamLatencies= */ Collections.emptyList());

Review Comment:
   nit: undo



##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java:
##########
@@ -273,7 +273,7 @@ private ParallelInstruction makeWindowingSourceInstruction(Coder<?> coder) {
         CloudObject.forClassName(
             "com.google.cloud.dataflow.sdk.util.TimerOrElement$TimerOrElementCoder");
     List<CloudObject> component =
-        Collections.singletonList(CloudObjects.asCloudObject(coder, /*sdkComponents=*/ null));
+        Collections.singletonList(CloudObjects.asCloudObject(coder, /* sdkComponents= */ null));

Review Comment:
   nit: undo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org