You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/08 06:19:10 UTC

[GitHub] [pulsar] youzipi opened a new pull request, #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

youzipi opened a new pull request, #17968:
URL: https://github.com/apache/pulsar/pull/17968

   Master Issue: #12271 #16991 
   
   ### Motivation
   
   Apply Maven Modernizer plugin to enforce we move away from legacy APIs.
   
   ### Modifications
   
   - fix violations in pulsar-broker package.
   
   ### Verifying this change
   
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/youzipi/pulsar/pull/2
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] youzipi commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
youzipi commented on PR #17968:
URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272284939

   > Cool! I think this PR actually closes #16991 and #12271?
   
   yes, we can close these issues.
   but there are still some modules not having this check, the list was made one year ago and the amount of modules is continuously growing (ex: pulsar-io modules).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece merged pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
nodece merged PR #17968:
URL: https://github.com/apache/pulsar/pull/17968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] youzipi commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
youzipi commented on PR #17968:
URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272265830

   @MarvinCai @tisonkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17968:
URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272287220

   @youzipi OK. I think we can narrow the scope to what that issue originally has. We can (you can! of course :)) create a new issue to track new effort. IIRC @MarvinCai has lees time to track #12271 and thus keep it open doesn't reflect the situation :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17968:
URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272512063

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17968:
URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272702447

   @codelipenghui you may change the PR description as:
   
   ```
   * This closes #12271.
   * This closes #16991.
   ```
   
   as mentioned in https://github.com/apache/pulsar/pull/17968#issuecomment-1272287220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org