You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/24 13:23:22 UTC

[GitHub] [skywalking] heihaozi opened a new issue #6619: A unit test can be better.

heihaozi opened a new issue #6619:
URL: https://github.com/apache/skywalking/issues/6619


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [X] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   In [MockRedisClusterClientConstructorInterceptor.java](https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/MockRedisClusterClientConstructorInterceptor.java), the unit test copied the original code. I think it should be implemented in a better way. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6619: A unit test can be better.

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #6619:
URL: https://github.com/apache/skywalking/issues/6619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org