You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pirk.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/23 10:15:20 UTC
[jira] [Commented] (PIRK-63) Generalize ResponderDriver to use a
RespondLauncher class
[ https://issues.apache.org/jira/browse/PIRK-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516041#comment-15516041 ]
ASF GitHub Bot commented on PIRK-63:
------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/93
> Generalize ResponderDriver to use a RespondLauncher class
> ---------------------------------------------------------
>
> Key: PIRK-63
> URL: https://issues.apache.org/jira/browse/PIRK-63
> Project: PIRK
> Issue Type: Improvement
> Components: Responder
> Affects Versions: 0.1.0
> Reporter: DarinJ
> Assignee: DarinJ
> Priority: Minor
> Fix For: 0.0.1
>
>
> Currently as discussed on the mailing list, the ResponderDriver uses a switch statement based off a string in the CLI or properties file to determine the framework to launch. This is require a code change to the ResponderDriver for every framework added.
> The solution is to create a ResponderLauncher Interface which each framework overrides.
> {quote}
> public interface ResponderLauncher {
> public run()
> }
> {quote}
> To do this, we the change the string specifying the framework to the name of the class implementing ResponderLauncher i.e. SparkResponderLauncher and instantiate via reflection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)