You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "shellwirt (via GitHub)" <gi...@apache.org> on 2023/04/28 17:11:32 UTC

[GitHub] [superset] shellwirt opened a new pull request, #23867: docs: Installation instruction changes

shellwirt opened a new pull request, #23867:
URL: https://github.com/apache/superset/pull/23867

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Updating installation instructions to contain up to date information of Superset's SECRET_KEY variable for production usage.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #23867: fix(docs): Installation instruction changes

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23867:
URL: https://github.com/apache/superset/pull/23867#issuecomment-1550374110

   Closing/reopening to kick-start CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] sfirke commented on pull request #23867: fix(docs): Installation instruction changes

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #23867:
URL: https://github.com/apache/superset/pull/23867#issuecomment-1550061600

   I believe this PR makes another open one obsolete: https://github.com/apache/superset/pull/20482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] shellwirt commented on pull request #23867: fix(docs): Installation instruction changes

Posted by "shellwirt (via GitHub)" <gi...@apache.org>.
shellwirt commented on PR #23867:
URL: https://github.com/apache/superset/pull/23867#issuecomment-1529890978

   After this PR, we can change the configuration of the [sidebar](https://docusaurus.io/docs/sidebar) in `docs/sidebars.js` so that we don't depend on each document metadata to define their position, making the documents much easier to work with.
   
   However we might need to document that change, so other contributors can add their pages in the file instead of defining metadata fields.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #23867: fix(docs): Installation instruction changes

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23867:
URL: https://github.com/apache/superset/pull/23867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] sfirke commented on pull request #23867: docs: Installation instruction changes

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #23867:
URL: https://github.com/apache/superset/pull/23867#issuecomment-1529792429

   To the reviewer(s): all of the `sidebar_position` changes are to move the "Running with Kubernetes" page up to its logical place, position 3.  All the other pages needed to get shuffled down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas closed pull request #23867: fix(docs): Installation instruction changes

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23867: fix(docs): Installation instruction changes
URL: https://github.com/apache/superset/pull/23867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org