[jira] [Resolved] (THRIFT-2745) C++ // Unit-test compilation fixes // pull request on github

["Konrad Grochowski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konrad Grochowski resolved THRIFT-2745.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.9.2
         Assignee: Konrad Grochowski

patch applied, thanks :)

one note - this test is currently disabled in makefiles, so although it's good it now compiles on windows, maybe it should be removed? or rebuilt?

> C++ // Unit-test compilation fixes // pull request on github
> ------------------------------------------------------------
>
>                 Key: THRIFT-2745
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2745
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library, Test Suite
>    Affects Versions: 1.0
>         Environment: Windows 7 (64bit)
> Microsoft Visual Studio 2012
>            Reporter: Sergei Nikulov
>            Assignee: Konrad Grochowski
>            Priority: Minor
>             Fix For: 0.9.2
>
>
> Issue 1:
> thrift\lib\cpp\test\concurrency\ThreadFactoryTests.h uses <unistd.h> for usleep().
> Replaced usleep() with THRIFT_SLEEP_USEC() and removed inclusion of unistd.h
> Issue 2:
> static const double ERROR;
> macro ERROR already defined in wingdi.h
> Replaced with TEST_ERROR, but perhaps it is better to find it more better name.
> PR: https://github.com/apache/thrift/pull/207



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)