You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/06 14:11:14 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1044: Fix warning found without -fno-builtin

xiaoxiang781216 commented on a change in pull request #1044:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1044#discussion_r820240050



##########
File path: netutils/webserver/httpd_dirlist.c
##########
@@ -193,10 +193,10 @@ ssize_t httpd_dirlist(int outfd, FAR struct httpd_fs_file *file)
           break;
         }
 
-      path = malloc(CONFIG_NAME_MAX);
+      path = malloc(PATH_MAX);
       ASSERT(path);
 
-      snprintf(path, CONFIG_NAME_MAX, "%s/%s",
+      snprintf(path, PATH_MAX, "%s/%s",
                file->path, dent->d_name);

Review comment:
       Done.

##########
File path: system/nxplayer/nxplayer.c
##########
@@ -1778,7 +1778,7 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer,
   struct audio_caps_desc_s cap_desc;
   struct ap_buffer_info_s  buf_info;
 #ifdef CONFIG_NXPLAYER_INCLUDE_MEDIADIR
-  char                path[128];
+  char                path[256];

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org