You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Anders Wallgren (JIRA)" <ji...@apache.org> on 2007/03/15 20:58:09 UTC
[jira] Created: (HTTPCORE-59) AbstractIOReactor.processNewChannels
calls SessionRequest.completed
AbstractIOReactor.processNewChannels calls SessionRequest.completed
-------------------------------------------------------------------
Key: HTTPCORE-59
URL: https://issues.apache.org/jira/browse/HTTPCORE-59
Project: HttpComponents Core
Issue Type: Bug
Components: HttpCore NIO
Affects Versions: 4.0-alpha4
Environment: Windows Vista
Reporter: Anders Wallgren
SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
(As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481297 ]
Oleg Kalnichevski commented on HTTPCORE-59:
-------------------------------------------
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me
Why? This is the place where new sessions get created and session requests can be considered completed. What would be a better approach?
> dearth of javadoc and comments in the code makes it challenging to figure this out
We happily take contributions
Oleg
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481319 ]
Anders Wallgren commented on HTTPCORE-59:
-----------------------------------------
Another aspect of this that has me puzzled: if the SessionRequest is marked completed before the response, then how do I cancel a request before the response is received? Currently, cancel is ignored if the request has been marked as completed.
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481325 ]
Oleg Kalnichevski commented on HTTPCORE-59:
-------------------------------------------
> I don't know why a SessionRequest is considered completed after the connection is established. Intuitively,
> I would think that a request is completed after the response has been received
SessionRequest is meant to represent a request for a new _session_ (or connection in the HTTP terms), right? New IOSession instance basically represents the result of this operation and a callback on the SessionRequestCallback interface represents the response. One is supposed to call SessionRequest#cancel() to abort the process of establishing a new connection (for instance when it takes too long), and not to cancel an individual request sent over the connection. Does this somehow make things a little clearer?
Oleg
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481327 ]
Anders Wallgren commented on HTTPCORE-59:
-----------------------------------------
The lightbulb over my head is starting to warm up -- let me digest that a bit and rework my code accordingly.
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCORE-59) AbstractIOReactor.processNewChannels
calls SessionRequest.completed
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-59.
---------------------------------------
Resolution: Invalid
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481314 ]
Anders Wallgren commented on HTTPCORE-59:
-----------------------------------------
Also, sorry about the comment on documentation -- my inner monologue escaped into the bug report...
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCORE-59)
AbstractIOReactor.processNewChannels calls SessionRequest.completed
Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481305 ]
Anders Wallgren commented on HTTPCORE-59:
-----------------------------------------
I guess the main problem here is that I don't understand the design. Thus, I don't know why a SessionRequest is considered completed after the connection is established. Intuitively, I would think that a request is completed after the response has been received.
> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>
> Key: HTTPCORE-59
> URL: https://issues.apache.org/jira/browse/HTTPCORE-59
> Project: HttpComponents Core
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.0-alpha4
> Environment: Windows Vista
> Reporter: Anders Wallgren
>
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging to figure this out.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org