You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/11/16 23:09:39 UTC
[jira] Commented: (ZOOKEEPER-3) syncLimit has slightly different
comments in the class header, and > inline with the variable.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778588#action_12778588 ]
Hadoop QA commented on ZOOKEEPER-3:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425142/ZOOKEEPER-3.patch
against trunk revision 835618.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/63/console
This message is automatically generated.
> syncLimit has slightly different comments in the class header, and > inline with the variable.
> -----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Benjamin Reed
> Assignee: Mahadev konar
> Priority: Trivial
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-3.patch
>
>
> syncLimit as documented in QuorumPeer is documented twice with two different aspects of in each instance. It should be better documented and unified. (Probably remove the second instance.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.