[GitHub] [dolphinscheduler] xdu-chenrj commented on pull request #14434: [DSIP-2019] Support zeppelin connections in the connection center, as well as external connections to the connection center in zeppelin tasks

["xdu-chenrj (via GitHub)" <gi...@apache.org>]

xdu-chenrj commented on PR #14434:
URL: https://github.com/apache/dolphinscheduler/pull/14434#issuecomment-1615469898

   > Hi, @xdu-chenrj , thanks for your contribution :D
   > 
   > Some suggestions for you before taking further look of this PR :
   > 
   > * You should better follow the PR template to describe this PR.
   > * Please add missing license header for `dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-zeppelin/pom.xml`.
   > * Please avoid using wild card import in codes, e.g. `import org.apache.dolphinscheduler.plugin.task.api.*;`.
   > * Please run `mvn spotless:apply` to format your code first.
   > * Please handle conflicts first.
   
   
   
   Okay, I got it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org