[GitHub] [spark] sarutak commented on a change in pull request #30859: [SPARK-33853][SQL] EXPLAIN CODEGEN doesn't show subquery code

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #30859:
URL: https://github.com/apache/spark/pull/30859#discussion_r546324286



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -228,6 +228,28 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
     }
   }
 
+  test("SPARK-33853: explain codegen - check presence of subquery") {
+    withTable("df1", "df2") {
+      withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "true",
+        SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {

Review comment:
       Ah, I noticed `DisableAdaptiveExecutionSuite`. I'll just remove `SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false"`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org