You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/09/24 00:36:57 UTC
Review Request 71535: Fixed certificate write functions for windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Joseph Wu.
Repository: mesos
Description
-------
The former implementation failed on Windows. By switching
to the recommended `BIO_` API for serializing the x509 data
to disk, we avoid that problem.
Diffs
-----
3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
Diff: https://reviews.apache.org/r/71535/diff/1/
Testing
-------
Tested "manually" within a private project on Windows.
Thanks,
Till Toenshoff
Re: Review Request 71535: Fixed certificate write functions for
windows.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/#review217921
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71535]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 24, 2019, 12:41 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71535/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2019, 12:41 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The former implementation failed on Windows. By switching
> to the recommended `BIO_` API for serializing the x509 data
> to disk, we avoid that problem.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
>
>
> Diff: https://reviews.apache.org/r/71535/diff/2/
>
>
> Testing
> -------
>
> Tested "manually" within a private project on Windows.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 71535: Fixed certificate write functions for
windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/#review217931
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 23, 2019, 5:41 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71535/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2019, 5:41 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The former implementation failed on Windows. By switching
> to the recommended `BIO_` API for serializing the x509 data
> to disk, we avoid that problem.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
>
>
> Diff: https://reviews.apache.org/r/71535/diff/2/
>
>
> Testing
> -------
>
> Tested "manually" within a private project on Windows.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 71535: Fixed certificate write functions for
windows.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/
-----------------------------------------------------------
(Updated Sept. 24, 2019, 12:41 a.m.)
Review request for mesos, Greg Mann and Joseph Wu.
Repository: mesos
Description (updated)
-------
The former implementation failed on Windows. By switching
to the recommended `BIO_` API for serializing the x509 data
to disk, we avoid that problem.
Diffs
-----
3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
Diff: https://reviews.apache.org/r/71535/diff/2/
Testing
-------
Tested "manually" within a private project on Windows.
Thanks,
Till Toenshoff
Re: Review Request 71535: Fixed certificate write functions for
windows.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/
-----------------------------------------------------------
(Updated Sept. 24, 2019, 12:40 a.m.)
Review request for mesos, Greg Mann and Joseph Wu.
Repository: mesos
Description (updated)
-------
Fixed certificate write functions for windows.
Diffs (updated)
-----
3rdparty/libprocess/src/ssl/utilities.cpp c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48
Diff: https://reviews.apache.org/r/71535/diff/2/
Changes: https://reviews.apache.org/r/71535/diff/1-2/
Testing
-------
Tested "manually" within a private project on Windows.
Thanks,
Till Toenshoff