[GitHub] [arrow-datafusion] nseekhao commented on pull request #6604: Support Expr::InList to Substrait::RexType

["nseekhao (via GitHub)" <gi...@apache.org>]

nseekhao commented on PR #6604:
URL: https://github.com/apache/arrow-datafusion/pull/6604#issuecomment-1587697785

   @jayzhan211 I believe `NOT IN` will be parsed into `Expr::InList` with `negated = true`.
   So I think we can implement the producer as you suggested.
   
   1. If matched to `Expr::InList`, turn the DF `InList` expression into `RexType::SingularOrList`
   2. If `expr.negated` is `true`
     i) Register `"not"` function: `let function_anchor = _register_function("not", extension_info);`
     ii) Wrap `RexType::SingularOrList` in `RexType::ScalarFunction` with `function_reference: function_anchor`
   3. Return the parsed expression
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org