You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/11 01:31:23 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
utchoang opened a new pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303
### Description
Fixes https://github.com/apache/cloudstack/issues/5302
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-896516857
@davidjumani You can refer to https://github.com/apache/cloudstack/blob/4.14/ui/scripts/zoneWizard.js#L4454, In case both `localstorageenabled` && `localstorageenabledforsystemvm` are enabled, the step of adding primary storage will be skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-900066730
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-900067171
@davidjumani can you please check again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-896427786
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-896429562
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-900052460
@utchoang That's right, my point is to skip just that step in an if condition rather than adding the redundant code of adding hosts and secondary storage in the if as well as else clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-900069165
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5303 (SL-JID-529)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-900066450
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5303: UI - Zone wizard - Fixes wrong add resource step with localstorageenabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5303:
URL: https://github.com/apache/cloudstack/pull/5303#issuecomment-896432230
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5303 (SL-JID-504)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org