[GitHub] [lucene] rmuir commented on a change in pull request #487: LUCENE-10234: Change module prefix to org.apache.*

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758721225



##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -66,7 +66,7 @@ subprojects {
               "X-Build-JDK"           : "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
               "X-Build-OS"            : "${System.properties['os.name']} ${System.properties['os.arch']} ${System.properties['os.version']}",
 
-              "Automatic-Module-Name" : "${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"
+              "Automatic-Module-Name" : "org.apache.${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"

Review comment:
       hmm, for sure I'm unhappy about the "analysis" missing, because `org.apache.lucene.common` seems pretty ambiguous. But I'd be happy with `org.apache.lucene.analysis_common` which is what I think your suggestion would create?
   
   But +1 to iterate here a little bit more (can we get "analysis" in the name some way or another), and then ping the mailing list with a printout just like what you showed here. If anyone has a strong opinion then they had a chance.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org