You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/10 16:11:09 UTC

[GitHub] [flink] PatrickRen opened a new pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

PatrickRen opened a new pull request #14021:
URL: https://github.com/apache/flink/pull/14021


   ## What is the purpose of the change
   
   This pull request adds error checking and retry strategy for FlinkKafkaInternalProducerITCase to make it more robust.
   
   ## Brief change log
   - Add error checking in `kafkaProducer.send()` callback.
   - Add retry for `kafkaConsumer.poll()` if nothing is retrieved from Kafka brokers in `assertRecord()`.
   
   
   ## Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724804461


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e (Tue Nov 10 16:13:08 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724820662


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] PatrickRen commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724811403


   Hi @becketqin , I think the modification you made in your own repo has already covered my thought of extending the timeout of kafkaConsumer.poll(), so I just cherry-picked your commit here. 
   
   Also I tried to run `testHappyPath` locally on my laptop after applying your changes this afternoon, and it failed again after two hours repeatedly running  because of a JUnit timeout. I checked the log and found nothing special. I'll extend the JUnit timeout to 60 seconds and try again tonight. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724820662


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417",
       "triggerID" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724820662


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417",
       "triggerID" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b1819154e14ebc0c9525536fba5757b136080bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b1819154e14ebc0c9525536fba5757b136080bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417) 
   * 6b1819154e14ebc0c9525536fba5757b136080bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] becketqin closed pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
becketqin closed pull request #14021:
URL: https://github.com/apache/flink/pull/14021


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] PatrickRen commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-725180030


   Looks like increasing the JUnit timeout to 60 secs indeed helps. I ran this case repeatedly for over 300 times locally on my laptop and everything looks good. @becketqin  Will you help to look at this PR? Thank you~ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] becketqin commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-725218181


   Merged to master.
   cb2d137adc9ea1e46a67513c1e0f2469bb05bff4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] becketqin commented on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-725216164


   @PatrickRen Thanks a lot for the thorough tests. The patch LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724820662


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417",
       "triggerID" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14021: [FLINK-13733][connector/kafka] Make FlinkKafkaInternalProducerITCase more robust

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14021:
URL: https://github.com/apache/flink/pull/14021#issuecomment-724820662


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417",
       "triggerID" : "685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b1819154e14ebc0c9525536fba5757b136080bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9439",
       "triggerID" : "6b1819154e14ebc0c9525536fba5757b136080bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 685a334e4b6fa71ee9a95c74aaf3b7ba2557d05e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9417) 
   * 6b1819154e14ebc0c9525536fba5757b136080bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9439) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org