You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/05/12 21:35:34 UTC
[Bug 4899] New: helper_app_pipe_open_windows doesn't work
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
Summary: helper_app_pipe_open_windows doesn't work
Product: Spamassassin
Version: 3.1.1
Platform: PC
OS/Version: Windows NT
Status: NEW
Severity: normal
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: bret.miller@wcg.org
The following line is used to pipe a file to stdin on a called program (like Pyzor):
if ($stdinfile) { $cmd .= " < '$stdinfile'"; }
However, windows XP and 2003 (at least) don't like either the space following
the < nor the single quotes around the filename. The line should read:
if ($stdinfile) { $cmd .= " <\"$stdinfile\""; }
I have verified this works with SA 3.1.1 to call Pyzor.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.0
------- Additional Comments From felicity@apache.org 2006-05-12 19:39 -------
if someone else with windows could verify that this works/doesn't break other
things, I'd be happy with the change (it should probably end up in 3.1 btw).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs testing / comment
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
------- Additional Comments From bret.miller@wcg.org 2006-05-12 19:36 -------
Oops.. guess it would help if I said this was in Util.pm
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.2.0 |3.1.4
------- Additional Comments From spamassassin@dostech.ca 2006-07-16 09:07 -------
we've basically done this in sa-update for 3.1 now...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
------- Additional Comments From bret.miller@wcg.org 2006-07-17 15:51 -------
I downloaded the latest snapshot from cvs and it works perfectly here. Thank you.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
------- Additional Comments From bret.miller@wcg.org 2006-07-12 15:47 -------
Well, Windows doesn't handle single-quoted file paths. At least not Windows XP
or Server 2003. So calling a program single-quoted always returns "bad command
or file name"...
Since the routine in question is only used for Windows systems, what could it
possibly break? I can't see how it would work for any Windows system at all the
way it is now.
All you have to do to verify it is go to a windows command prompt and try
running "cmd" and 'cmd' to see the error.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4899] helper_app_pipe_open_windows doesn't work
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4899
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From felicity@apache.org 2006-07-17 01:20 -------
Ok, I've committed a patch to shift to double quotes. It seems trivial to me, so...
3.2:
Sending SpamAssassin/Util.pm
Transmitting file data .cd
Committed revision 422589.
3.1:
Sending SpamAssassin/Util.pm
Transmitting file data .
Committed revision 422590.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.