[jira] Commented: (OFBIZ-2376) Add new response type "Wait Replacement Reserved" for returns of order

["Vikas Mayur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704058#action_12704058 ] 

Vikas Mayur commented on OFBIZ-2376:
------------------------------------

Hi Deepesh,

I have reviewed this patch and would like to suggest following changes:

1) There was no need to define new eca services. Please use the existing eca on UpdateReturnHeader service.
2) Please revert the changes to the service processWaitReplacementReturn. These are not required at all. To see why, refer to OrderReturnServices.java line number 1353 {code} if (returnHeader != null && UtilValidate.isNotEmpty(returnItems)) {{code}
3) The new service "processWaitReplacementReservedReturn" should be cleaned a bit. There are necessary lines which can be removed.
4) The description of service need to be improved and should be specific about what the service is trying to do.

I will commit this patch once all the issues are resolved.

Vikas

> Add new response type "Wait Replacement Reserved" for returns of order 
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-2376
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2376
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2376.patch
>
>
> *Implementation Notes:*
> * Add new response type "Wait Replacement Reserved" for returns of order.
> * When return is accepted immediately create replacement order, in the "Held" status; 
> * When original item return is received  find HELD replacement order(s) and auto-set the status to APPROVED to clear them for fulfillmen
> Do following:
> a. Trigger on change to return status RETURN_ACCEPTED -- For creating zero amount replacement order in HELD status.
> b. Trigger on change to return status RETURN_RECEIVED  -- For changing the status of order(s) from HELD to APPROVED.
> c. New service has to be implemented like processCrossShipReplacementReturn, but call it  "processWaitReplacementReservedReturn

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.