You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/03/18 00:26:27 UTC
Re: Review Request 57428: Improvement to case where Exception (base
class) is thrown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57428/#review169349
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 17, 2017, 11:57 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57428/
> -----------------------------------------------------------
>
> (Updated March 17, 2017, 11:57 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-1666
> https://issues.apache.org/jira/browse/ATLAS-1666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Bug lists areas in code where *Exception* is thrown instead of a specialized class. The rationale being that specialized class shows awareness to exception thrown and thus better handled.
>
> **General approach**
> The places described in the bug are now repalced with *AtlasBaseException*. A new *AtlasErrorCode* has been defined for the areas where base class *Exception* is being used.
>
> **Areas Covered**
> 1. *ActiveInstanceState.java*
> 2. *AtlasPluginClassLoader.java* Ignored for now.
> 3. *AbstractParam.java*
> 4. *QuickStart.java*
> 5. *SetupSteps.java*
> 6. *FalconHook.java*
> 7. *AtlasLdapAuthenticationProvider.java*
> 8. *FalconEventPublisher.java*
> 9. *AtlasADAuthenticationProvider.java*
> 10. *StormHook.java*
> 11. *FalconBridge.java*
> 12. *EmbeddedServer.java*
> 13. *StormTopologyUtil.java*
> 15. *SqoopHook.java*
> 16. *HiveHook.java*
> 17. *HiveMetaStoreBridge.java*
>
> Some areas that are deemed too critical to overall application stability or hard to verify have been ignored.
>
> Will be updating the patch with additional changes as they are available.
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java d1a7e87
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java dce55c4
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 16835cf
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 6fb27e5
> addons/storm-bridge-shim/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 45eac72
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java d646fba
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5054cf0
> notification/src/main/java/org/apache/atlas/hook/AtlasHookException.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 21ecca9
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 8087782
> webapp/src/main/java/org/apache/atlas/web/params/BooleanParam.java d81fb6f
> webapp/src/main/java/org/apache/atlas/web/params/DateTimeParam.java 4b417e6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6b5ae90
> webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceState.java a489bcf
> webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java e615a5b
> webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java c97cc95
>
>
> Diff: https://reviews.apache.org/r/57428/diff/8/
>
>
> Testing
> -------
>
> Debugger step-thru to similate exception condition.
> Run all unit tests and ITs.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>