You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/12/08 11:52:31 UTC
Review Request 74244: ATLAS-4715 - UI: Option to delete assigned term from deleted entity is visible.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74244/
-----------------------------------------------------------
Review request for atlas and Prasad Pawar.
Bugs: ATLAS-4715
https://issues.apache.org/jira/browse/ATLAS-4715
Repository: atlas
Description
-------
If a deleted entity is assigned a term and then deleted, viewing the entity with 'historical entities' filter enabled not only shows the assigned term but also the option to remove said term from the entity. This goes against the condition that assigned terms and classifications should not be removed from deleted entities.
Diffs
-----
dashboardv2/public/css/scss/common.scss 73f67c75c
dashboardv3/public/css/scss/common.scss 93f5ddbdd
Diff: https://reviews.apache.org/r/74244/diff/1/
Testing
-------
Manually tested for the above mentioned scenario on both UI( Classic & New-ui).
Thanks,
Farhan Khan
Re: Review Request 74244: ATLAS-4715 - UI: Option to delete assigned term from deleted entity is visible.
Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74244/#review224981
-----------------------------------------------------------
Ship it!
Ship It!
- Prasad Pawar
On Dec. 8, 2022, 11:52 a.m., Farhan Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74244/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2022, 11:52 a.m.)
>
>
> Review request for atlas and Prasad Pawar.
>
>
> Bugs: ATLAS-4715
> https://issues.apache.org/jira/browse/ATLAS-4715
>
>
> Repository: atlas
>
>
> Description
> -------
>
> If a deleted entity is assigned a term and then deleted, viewing the entity with 'historical entities' filter enabled not only shows the assigned term but also the option to remove said term from the entity. This goes against the condition that assigned terms and classifications should not be removed from deleted entities.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/common.scss 73f67c75c
> dashboardv3/public/css/scss/common.scss 93f5ddbdd
>
>
> Diff: https://reviews.apache.org/r/74244/diff/1/
>
>
> Testing
> -------
>
> Manually tested for the above mentioned scenario on both UI( Classic & New-ui).
>
>
> Thanks,
>
> Farhan Khan
>
>