You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/28 15:51:05 UTC

[PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

He-Pin opened a new pull request, #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068

   Motivation: 
   
   These method is used in other pekko projects.
   Remove the `inline def` in scala 3
   
   Or we have to find another way 
   refs: https://github.com/apache/incubator-pekko-connectors/pull/412
   refs: https://github.com/apache/incubator-pekko-connectors/actions/runs/7686045276/job/20944445485?pr=412#step:5:506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913731732

   Ah I think I know what the problem is, Pekko Http 1.1.x is not being compiled against Pekko 1.1.x but instead Pekko 1.0.x and because Pekko 1.0.x doesn't have the `inline` keyword it didn't get inlined within Pekko Http 1.1.x so Pekko Http 1.1.x is still expecting the inline methods to exist in bytecode but they don't because they are being stripped.
   
   Ill have to think about this, worst case scenario is that we have to remove all the Scala 3 inline keywords


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913735530

   > That's true, I think @pjfanning will not support we backport this inline support back to 1.0.x.
   > 
   > An in source helper method will not help the Http 1.0.x without inkine backport.
   
   I found a possible solution using https://docs.scala-lang.org/scala3/reference/other-new-features/targetName.html, making a PR now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1914065759

   @He-Pin Shall we close this since https://github.com/apache/incubator-pekko/pull/1070 is merged? We can re-open it later if that solution doesn't work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913735357

   That's true, I think @pjfanning will not support we backport this inline support back to 1.0.x.
   
   An in source helper method will not help the Http 1.0.x without inkine backport.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913738415

   > But not sure whether if that just invalid the inline support, somekind of kotlin 's JvmName annotation thing.
   
   Will explain in PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913737250

   But not sure whether if that just invalid the inline support, somekind of kotlin 's JvmName annotation thing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #1068: chore: remove the inline modifier from pekko util.
URL: https://github.com/apache/incubator-pekko/pull/1068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913729295

   So FYI whats the weird thing here is that its known that `inline def` does not work if its called within Java `*.java` source code however its definitely meant to work when called within `*.scala` source code and the whole point of Scala compiler is that its meant to, well, inline that method so with
   
   ```
   [error] Test docs.javadsl.SqsSourceTest failed: java.lang.NoSuchMethodError: org.apache.pekko.util.FutureConverters$FutureOps$.asJava$extension(Lscala/concurrent/Future;)Ljava/util/concurrent/CompletionStage;, took 0.0 sec
   ```
   
   you shouldn't even see `org.apache.pekko.util.FutureConverters$FutureOps$.asJava$extension(Lscala/concurrent/Future;)Ljava/util/concurrent/CompletionStage` in the stack trace, it should be just `CompletionStage` at this point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1913741960

   PR created at https://github.com/apache/incubator-pekko/pull/1070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: remove the inline modifier from pekko util. [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1068:
URL: https://github.com/apache/incubator-pekko/pull/1068#issuecomment-1914095193

   Ok,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org