You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/08 18:33:15 UTC
Review Request 64457: Instructed frameworks to avoid setting the offer
operation 'id' field.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64457/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-8054
https://issues.apache.org/jira/browse/MESOS-8054
Repository: mesos
Description
-------
The framework API side of offer operation feedback has not yet been
implemented, so frameworks should currently avoid setting this field.
See MESOS-8054.
Diffs
-----
include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413
include/mesos/v1/mesos.proto 0ea17a83705774a69a301599c9c905e08cdef4d1
Diff: https://reviews.apache.org/r/64457/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 64457: Instructed frameworks to avoid setting the
offer operation 'id' field.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64457/#review193273
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 6:53 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64457/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 6:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-8054
> https://issues.apache.org/jira/browse/MESOS-8054
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The framework API side of offer operation feedback has not yet been
> implemented, so frameworks should currently avoid setting this field.
> See MESOS-8054.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413
> include/mesos/v1/mesos.proto 0ea17a83705774a69a301599c9c905e08cdef4d1
>
>
> Diff: https://reviews.apache.org/r/64457/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64457: Instructed frameworks to avoid setting the
offer operation 'id' field.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64457/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 6:53 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-8054
https://issues.apache.org/jira/browse/MESOS-8054
Repository: mesos
Description
-------
The framework API side of offer operation feedback has not yet been
implemented, so frameworks should currently avoid setting this field.
See MESOS-8054.
Diffs (updated)
-----
include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413
include/mesos/v1/mesos.proto 0ea17a83705774a69a301599c9c905e08cdef4d1
Diff: https://reviews.apache.org/r/64457/diff/2/
Changes: https://reviews.apache.org/r/64457/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 64457: Instructed frameworks to avoid setting the
offer operation 'id' field.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64457/#review193272
-----------------------------------------------------------
include/mesos/mesos.proto
Line 1976 (original), 1980 (patched)
<https://reviews.apache.org/r/64457/#comment271825>
s/;/; // Experimental./
include/mesos/v1/mesos.proto
Line 1957 (original), 1961 (patched)
<https://reviews.apache.org/r/64457/#comment271826>
ditto.
- Vinod Kone
On Dec. 8, 2017, 6:33 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64457/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 6:33 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-8054
> https://issues.apache.org/jira/browse/MESOS-8054
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The framework API side of offer operation feedback has not yet been
> implemented, so frameworks should currently avoid setting this field.
> See MESOS-8054.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413
> include/mesos/v1/mesos.proto 0ea17a83705774a69a301599c9c905e08cdef4d1
>
>
> Diff: https://reviews.apache.org/r/64457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>