You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/02/22 01:10:40 UTC
[GitHub] [echarts] linghaoSu opened a new pull request #16554: fix precision caused by use calculated data
linghaoSu opened a new pull request #16554:
URL: https://github.com/apache/echarts/pull/16554
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
avoid use calculated angle to get span range data
### Fixed issues
- https://github.com/apache/echarts/issues/16550
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
the precision problem caused by angle range span was calculated by radian angle,
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
<img width="712" alt="image" src="https://user-images.githubusercontent.com/56526981/155044803-7b434905-db58-4eb9-8181-b4d75bf0b6c2.png">
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
so we use original degree angle to get angle span, and then transform to radian angle ,avoid more transformation to cause precision problem.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
<img width="754" alt="image" src="https://user-images.githubusercontent.com/56526981/155044849-57b26d73-3a9c-49a4-b0af-1cdefd8b57f5.png">
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
`test/gauge-simple.html`
## Others
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16554: fix precision caused by use calculated data
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16554:
URL: https://github.com/apache/echarts/pull/16554#issuecomment-1047335062
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org