You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/05 18:44:41 UTC

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8925: Add release refinements from 0.35.2 release

mistercrunch commented on a change in pull request #8925: Add release refinements from 0.35.2 release
URL: https://github.com/apache/incubator-superset/pull/8925#discussion_r363110021
 
 

 ##########
 File path: RELEASING/Dockerfile.from_local_tarball
 ##########
 @@ -56,7 +56,6 @@ RUN npm ci \
 
 WORKDIR /home/superset/apache-superset-incubating-$VERSION
 RUN pip install --upgrade setuptools pip \
-    && pip install -r requirements.txt \
 
 Review comment:
   That makes the docker image non deterministic which I think is an issue. Personally I vote for having a very deterministic docker build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org