You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/02/13 07:10:53 UTC

[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #5260: Minor: refactor ParquetExec roundtrip tests

viirya commented on code in PR #5260:
URL: https://github.com/apache/arrow-datafusion/pull/5260#discussion_r1104068340


##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -550,6 +550,11 @@ pub(crate) mod test_util {
     use parquet::file::properties::WriterProperties;
     use tempfile::NamedTempFile;
 
+    /// Writes `batches` to a temporary parquet file
+    ///
+    /// If multi_page is set to `true`, the parquet file is written
+    /// with 2 rows per data page (used to test page filtering and
+    /// boundaries)

Review Comment:
   ```suggestion
       /// If multi_page is set to `true`, all batches are written into 
       /// one temporary parquet file and the parquet file is written
       /// with 2 rows per data page (used to test page filtering and
       /// boundaries).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org