You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Camille Fournier <sk...@gmail.com> on 2011/06/22 18:55:12 UTC
Review Request: ZOOKEEPER-1046: Creating a new sequential node results in a
ZNODEEXISTS error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/942/
-----------------------------------------------------------
Review request for zookeeper and Benjamin Reed.
Summary
-------
see https://issues.apache.org/jira/browse/ZOOKEEPER-1046
Diffs
-----
/src/java/main/org/apache/zookeeper/server/DataNode.java 1136231
/src/java/main/org/apache/zookeeper/server/DataTree.java 1136231
/src/java/main/org/apache/zookeeper/server/LogFormatter.java 1136231
/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1136231
/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 1136231
/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 1136231
/src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1136231
/src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1136231
/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1136231
/src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1136231
/src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 1136231
/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1136231
/src/java/test/org/apache/zookeeper/server/DataTreeUnitTest.java 1136231
/src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java 1136231
/src/java/test/org/apache/zookeeper/server/SerializationPerfTest.java 1136231
/src/java/test/org/apache/zookeeper/test/DataTreeTest.java 1136231
/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 1136231
/src/zookeeper.jute 1136231
Diff: https://reviews.apache.org/r/942/diff
Testing
-------
unit testing
Thanks,
Camille
Re: Review Request: ZOOKEEPER-1046: Creating a new sequential node results
in a ZNODEEXISTS error
Posted by Camille Fournier <sk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/942/#review883
-----------------------------------------------------------
/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
<https://reviews.apache.org/r/942/#comment1923>
Should remove this println
/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java
<https://reviews.apache.org/r/942/#comment1924>
Should remove this println
Otherwise looks good I think
- Camille
On 2011-06-22 16:55:12, Camille Fournier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/942/
> -----------------------------------------------------------
>
> (Updated 2011-06-22 16:55:12)
>
>
> Review request for zookeeper and Benjamin Reed.
>
>
> Summary
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-1046
>
>
> Diffs
> -----
>
> /src/java/main/org/apache/zookeeper/server/DataNode.java 1136231
> /src/java/main/org/apache/zookeeper/server/DataTree.java 1136231
> /src/java/main/org/apache/zookeeper/server/LogFormatter.java 1136231
> /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1136231
> /src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 1136231
> /src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 1136231
> /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1136231
> /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1136231
> /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1136231
> /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1136231
> /src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 1136231
> /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1136231
> /src/java/test/org/apache/zookeeper/server/DataTreeUnitTest.java 1136231
> /src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java 1136231
> /src/java/test/org/apache/zookeeper/server/SerializationPerfTest.java 1136231
> /src/java/test/org/apache/zookeeper/test/DataTreeTest.java 1136231
> /src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 1136231
> /src/zookeeper.jute 1136231
>
> Diff: https://reviews.apache.org/r/942/diff
>
>
> Testing
> -------
>
> unit testing
>
>
> Thanks,
>
> Camille
>
>