You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2024/07/17 10:19:53 UTC
[PR] MINOR: Various cleanups in metadata [kafka]
mimaison opened a new pull request, #16610:
URL: https://github.com/apache/kafka/pull/16610
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Various cleanups in metadata [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16610:
URL: https://github.com/apache/kafka/pull/16610#issuecomment-2238844809
@mimaison please fix the build error on scala 2.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Various cleanups in metadata [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #16610:
URL: https://github.com/apache/kafka/pull/16610#issuecomment-2239252863
My bad. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Various cleanups in metadata [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16610:
URL: https://github.com/apache/kafka/pull/16610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Various cleanups in metadata [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16610:
URL: https://github.com/apache/kafka/pull/16610#discussion_r1682639234
##########
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##########
@@ -101,9 +101,7 @@ public static class Loader {
private Optional<String> metadataLogDir = Optional.empty();
public Loader addLogDirs(Collection<String> logDirs) {
Review Comment:
This method is useless, but it seems `addLogDir` is used in for-each always. Hence, we can replace that by `addLogDirs` and then remove `addLogDir`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Various cleanups in metadata [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #16610:
URL: https://github.com/apache/kafka/pull/16610#discussion_r1682908931
##########
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##########
@@ -101,9 +101,7 @@ public static class Loader {
private Optional<String> metadataLogDir = Optional.empty();
public Loader addLogDirs(Collection<String> logDirs) {
Review Comment:
That's a good point! I've removed `addLogDir()`.
Overall there are a bunch of unused methods in test utilities in this module. I decided to not touch them as I know there's some work in progress in this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org