Re: [PR] Add filters to Task Instances Tab [airflow]

["Pei-Cheng-Yu (via GitHub)" <gi...@apache.org>]

Pei-Cheng-Yu commented on code in PR #56920:
URL: https://github.com/apache/airflow/pull/56920#discussion_r2506522091


##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -247,6 +274,20 @@ export const useFilterConfigs = () => {
       label: translate("common:taskId"),
       type: FilterTypes.TEXT,
     },
+    [SearchParamsKeys.TASK_STATE]: {
+      icon: <MdCheckCircle />,
+      label: translate("common:state"),
+      options: taskInstanceStateOptions.items.map((option) => ({
+        label:
+          option.value === "all" ? (
+            translate(option.label)
+          ) : (
+            <StateBadge state={option.value as TaskInstanceState }>{translate(option.label)}</StateBadge>
+          ),
+        value: option.value,
+      })),
+      type: FilterTypes.SELECT,

Review Comment:
   solved, now choosing "All States" will reset state's filter, and I just realize that the state filter on the "Dag Runs" veiw page has the same issue, should I open a new PR for that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org