You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "moremind (via GitHub)" <gi...@apache.org> on 2023/09/12 14:03:00 UTC
[GitHub] [shenyu] moremind opened a new pull request, #5149: [type:fix] fix k8s example error
moremind opened a new pull request, #5149:
URL: https://github.com/apache/shenyu/pull/5149
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] runqi-zhao commented on pull request #5149: [type:fix] fix k8s example error
Posted by "runqi-zhao (via GitHub)" <gi...@apache.org>.
runqi-zhao commented on PR #5149:
URL: https://github.com/apache/shenyu/pull/5149#issuecomment-1716876183
The problem is in the shenyu-zookeper.yaml file, where the zookeepr image is out of date and should be changed to:
```yml
spec.
containers.
- image: zookeeper:latest
```
I verified this on top of my github actions: https://github.com/runqi-zhao/shenyu/tree/fix-k8s-examples-http, https://github.com/runqi-zhao/shenyu/actions/runs/6167386226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] moremind commented on pull request #5149: [type:fix] fix k8s example error
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5149:
URL: https://github.com/apache/shenyu/pull/5149#issuecomment-1716890700
> ```yaml
> latest
> ```
thanks for your notice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yunlongn merged pull request #5149: [type:fix] fix k8s example error
Posted by "yunlongn (via GitHub)" <gi...@apache.org>.
yunlongn merged PR #5149:
URL: https://github.com/apache/shenyu/pull/5149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5149: [type:fix] fix k8s example error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5149:
URL: https://github.com/apache/shenyu/pull/5149#issuecomment-1716037417
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5149](https://app.codecov.io/gh/apache/shenyu/pull/5149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aef1baa) into [master](https://app.codecov.io/gh/apache/shenyu/commit/5c561d98ec02da2e8b952c119286e5cd98bdb873?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c561d9) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5149 +/- ##
============================================
- Coverage 61.10% 61.02% -0.08%
+ Complexity 8471 8464 -7
============================================
Files 1242 1242
Lines 37342 37341 -1
Branches 3523 3523
============================================
- Hits 22817 22788 -29
- Misses 12562 12586 +24
- Partials 1963 1967 +4
```
[see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5149/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org