You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/06/12 07:55:39 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7620: [AGENT] host os accepted if only the first word is defined for the cluster
DaanHoogland opened a new pull request, #7620:
URL: https://github.com/apache/cloudstack/pull/7620
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #7616
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1587631638
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1591053234
@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1587448093
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1587451207
@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1587583842
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7620?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7620](https://app.codecov.io/gh/apache/cloudstack/pull/7620?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (64fe13d) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/0d3ac9f8d9604575065d7841cd021f222a63551e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d3ac9f) will **increase** coverage by `0.00%`.
> The diff coverage is `48.14%`.
```diff
@@ Coverage Diff @@
## 4.18 #7620 +/- ##
=========================================
Coverage 12.98% 12.98%
- Complexity 8984 8989 +5
=========================================
Files 2716 2716
Lines 256329 256343 +14
Branches 39974 39981 +7
=========================================
+ Hits 33275 33291 +16
+ Misses 218892 218885 -7
- Partials 4162 4167 +5
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java](https://app.codecov.io/gh/apache/cloudstack/pull/7620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3Iva3ZtL2Rpc2NvdmVyZXIvTGlidmlydFNlcnZlckRpc2NvdmVyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../secondarystorage/SecondaryStorageManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZXMvc2Vjb25kYXJ5LXN0b3JhZ2UvY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zZWNvbmRhcnlzdG9yYWdlL1NlY29uZGFyeVN0b3JhZ2VNYW5hZ2VySW1wbC5qYXZh) | `6.58% <56.52%> (+1.97%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7620/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
URL: https://github.com/apache/cloudstack/pull/7620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1592171374
<b>[SF] Trillian test result (tid-6738)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7620-t6738-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 77.65 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.30 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1586836125
> @weizhouapache , architecturally I don't whink this is the best solution but it will allow running environments to keep running. I don't know of an example where two different OSses use the same first word in their name, but if that exists, this won't work (i think for our Rocky and Red instances it will work).
@DaanHoogland
this might work, at least restarting cloudstack-agent should.
when all cloudstack-agent are started, all agent should have the correct Host.OS in host_details
I will test it
another option might be updating existing Host.OS in host_details (mostly rocky/rhel). is alma impacted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov merged pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov merged PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1591090906
@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1586788642
@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1592240966
<b>[SF] Trillian test result (tid-6739)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7620-t6739-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1591052141
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1586784168
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1587447000
> I will test it
thanks
> another option might be updating existing Host.OS in host_details (mostly rocky/rhel). is alma impacted?
I was thinking of that as well, but we cannot be sure to be complete and correct with this strategy. Rocky and Red make us make assumptions that might not be correct and as you mentioned, I forgot about Alma. This is not a problem btw as it is called "AlmaLinux".
To be sure we would need to check every possible host type that is supported and query "Host.OS" from the host_details tables. Can we be sure about the limits of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1586783501
@weizhouapache , architecturally I don't whink this is the best solution but it will allow running environments to keep running. I don't know of an example where two different OSses use the same first word in their name, but if that exists, this won't work (i think for our Rocky and Red instances it will work).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1586820793
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7620: [AGENT] host os accepted if only the first word is defined for the cluster
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7620:
URL: https://github.com/apache/cloudstack/pull/7620#issuecomment-1591088312
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org