You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/08/22 18:58:44 UTC

[GitHub] [bookkeeper] sijie commented on a change in pull request #2149: Issue #2148: Support shell subcommands to print usage when no args

sijie commented on a change in pull request #2149: Issue #2148: Support shell subcommands to print usage when no args
URL: https://github.com/apache/bookkeeper/pull/2149#discussion_r316837244
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/BookieShellCommand.java
 ##########
 @@ -43,6 +43,10 @@ public BookieShellCommand(String shellCmdName,
 
     @Override
     public int runCmd(String[] args) throws Exception {
+        if (args.length <= 0) {
 
 Review comment:
   @murong00 I don't think this change is correct. there are commands that don't have any args.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services