You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by godfreyhe <gi...@git.apache.org> on 2017/10/12 11:53:00 UTC

[GitHub] flink pull request #4815: [FLINK-7802] [hotfix] Exception occur when empty f...

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/4815

    [FLINK-7802] [hotfix] Exception occur when empty field collection was pushed into CSVTableSource

    ## What is the purpose of the change
    
    *This pull request fix the bug: Exception occur when empty field collection was pushed into CSVTableSource*
    
    
    ## Brief change log
    
      - *Handle empty field collection in CSVTableSource when project push down*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Add integration tests for SQL like: select count(1) from csv_table*
      
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-7802

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4815
    
----
commit 5694fb2fad223f733be9e92512f6534e0e3d37bb
Author: godfreyhe <go...@163.com>
Date:   2017-10-12T11:12:47Z

    [FLINK-7802] [hotfix] Exception occur when empty field collection was pushed into CSVTableSource

----


---

[GitHub] flink pull request #4815: [FLINK-7802] [hotfix] Exception occur when empty f...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4815


---

[GitHub] flink issue #4815: [FLINK-7802] [hotfix] Exception occur when empty field co...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4815
  
    Thanks for the PR @godfreyhe. 
    The fix looks good, but I don't think we need three end-to-end integration tests to check the behavior. I'll add a unit test and will remove the integration tests before merging.


---