You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Vladimir Gorej (JIRA)" <ji...@apache.org> on 2010/04/03 21:33:27 UTC
[jira] Created: (LOG4PHP-109) patch for Throwable information
associated with logging event
patch for Throwable information associated with logging event
-------------------------------------------------------------
Key: LOG4PHP-109
URL: https://issues.apache.org/jira/browse/LOG4PHP-109
Project: Log4php
Issue Type: New Feature
Components: Code, Documentation, Tests
Affects Versions: 2.2, 2.3
Environment: PHP
Reporter: Vladimir Gorej
I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Gorej updated LOG4PHP-109:
-----------------------------------
Attachment: (was: throwableInfo.patch)
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Gorej updated LOG4PHP-109:
-----------------------------------
Attachment: throwableinfo.patch
Patch with Fixed unit test for LoggerRendererException
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.0
> Environment: PHP
> Reporter: Vladimir Gorej
> Fix For: 2.1
>
> Attachments: throwableinfo.patch, throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Grobmeier resolved LOG4PHP-109.
-----------------------------------------
Resolution: Fixed
Committed with rv937159
Please discuss on the dev list for further changes with this issue
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.0
> Environment: PHP
> Reporter: Vladimir Gorej
> Fix For: 2.1
>
> Attachments: throwableinfo.patch, throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859662#action_12859662 ]
Christian Grobmeier commented on LOG4PHP-109:
---------------------------------------------
Hello,,
this patch is great but:
- i had to remove BSD license in favour to Apache License
- i removed some doc tags, like @author. On this project we agreed not to use it
Is this acceptable for you? If yes, then read on because
my LoggerRendererExceptionTest::testRender function fails on a Mac
You check the lenght here which should be 3986 but mine is 3837
Any ideas why? Probably an operating system issue
Cheers
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859743#action_12859743 ]
Christian Grobmeier commented on LOG4PHP-109:
---------------------------------------------
Hi,
yeah, of course you'll get into the contributors section :-) Hopefully you'll enter the comitters section one day!
Thanks about diving into the test - that saves work for me
Christian
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Grobmeier updated LOG4PHP-109:
----------------------------------------
Fix Version/s: 2.1
Affects Version/s: 2.0
(was: 2.2)
(was: 2.3)
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.0
> Environment: PHP
> Reporter: Vladimir Gorej
> Fix For: 2.1
>
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (LOG4PHP-109) patch for Throwable
information associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853187#action_12853187 ]
Vladimir Gorej edited comment on LOG4PHP-109 at 4/4/10 7:50 AM:
----------------------------------------------------------------
Patch for throwable information. With this patch, it is possible to log exceptions with user messages in fashion:
try {
// some actions
} catch (Exception $ex) {
Logger::getLogger('test')->warn('Error while something...', $ex);
}
Exception is assigned to the logger as caller object. Logger recozgnizes caller object as exception and passes it forward to the LoggerLoggingEvent. LoggerLoggingEvent::getThrowableInformation() now returns instance of LoggerThrowableInformation. Support for nested exception chains that php 5.3 now supports is also implemented. I also added renderer for nested exception chains. Patch also contains complete unitest with full coverage for new patch functionality.
was (Author: char0n):
patch for throwable info
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Gorej updated LOG4PHP-109:
-----------------------------------
Attachment: throwableInfo.patch
Tabbified version of my previous patch upload; spaces replaced for tabs after reading "contributing patches" section.
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vladimir Gorej updated LOG4PHP-109:
-----------------------------------
Attachment: throwableInfo.patch
patch for throwable info
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Vladimir Gorej (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859704#action_12859704 ]
Vladimir Gorej commented on LOG4PHP-109:
----------------------------------------
Hi Christian,
> - i had to remove BSD license in favour to Apache License
Of course, I have no problem with that
> - - i removed some doc tags, like @author. On this project we agreed not to use it
No problem with that either, but since there is nothing else to link me to this patch,
do I get it to the contributors list ? :)
I will dive into LoggerRendererExceptionTest::testRender tonight. It is definitely OS issue.
In patch I am using platform dependent PHP_EOL. I will attach corrected patch in a couple
of days.
I am glad that this patch will get into log4php. Thanks
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.2, 2.3
> Environment: PHP
> Reporter: Vladimir Gorej
> Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LOG4PHP-109) patch for Throwable information
associated with logging event
Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860128#action_12860128 ]
Christian Grobmeier commented on LOG4PHP-109:
---------------------------------------------
Hi,
i was reviewing it. It works with testcases, but I have a question.
do we really need a refernence to the Logger object in LoggerThrowableInformation? I think not and would like to delete it out, if you have no objections on that
I will commit it without the reference and slightly modified, but maybe you could review my changes and discuss further
Cheers
Christian
> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
> Key: LOG4PHP-109
> URL: https://issues.apache.org/jira/browse/LOG4PHP-109
> Project: Log4php
> Issue Type: New Feature
> Components: Code, Documentation, Tests
> Affects Versions: 2.0
> Environment: PHP
> Reporter: Vladimir Gorej
> Fix For: 2.1
>
> Attachments: throwableinfo.patch, throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. With this patch applied it will be possible to log exceptions and nested exceptions with their full stack traces
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.