You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/07/18 16:41:26 UTC
[GitHub] zeppelin pull request #3082: [ZEPPELIN-3636] Add timeout for s3 amazon bucke...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3082
[ZEPPELIN-3636] Add timeout for s3 amazon bucket endpoint
### What is this PR for?
If there is no connection to amazonaws, app will wait for 2 minutes during setup:
```
INFO [2018-07-13 14:45:19,644] (Helium.java[loadConf]:103) - Add helium local registry /opt/zeppelin/product/helium
INFO [2018-07-13 14:45:19,645] (Helium.java[loadConf]:100) - Add helium online registry https://s3.amazonaws.com/helium-package/helium.json
ERROR [2018-07-13 14:47:27,098] (HeliumOnlineRegistry.java[getAll]:80) - Connect to s3.amazonaws.com:443 [s3.amazonaws.com/54.231.120.10] failed: Connection timed out (Connection timed out)
INFO [2018-07-13 14:47:28,104] ( ContextHandler.java[doStart]:744) - Started o.e.j.w.WebAppContext@161479c6
```
Even if Amazon S3 notebook storage wasn't configured Helium goes to zeppelin.notebook.s3.endpoint.
It would be nice if we could set timeout for s3 bucket if we know that there is no connection to amazonaws.
### What type of PR is it?
Improvement
### What is the Jira issue?
issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3636
### How should this be tested?
* Log after setting timeout property to 20000 in zeppelin-site.xml:
```
INFO [2018-07-18 19:35:55,514] ({main} Helium.java[loadConf]:103) - Add helium local registry /home/egklimov/IdeaProjects/zeppelin/helium
INFO [2018-07-18 19:35:55,514] ({main} Helium.java[loadConf]:100) - Add helium online registry https://s3.amazonaws.com/helium-package/helium.json
ERROR [2018-07-18 19:36:15,690] ({main} HeliumOnlineRegistry.java[getAll]:91) - Connect to s3.amazonaws.com:443 [s3.amazonaws.com/192.168.65.17] failed: connect timed out
INFO [2018-07-18 19:36:16,823] ({main} ContextHandler.java[doStart]:744) - Started o.e.j.w.WebAppContext@6107227e
```
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation?
Yes, information about Zeppelin Properties updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3636
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3082
----
commit 7d2c4d1786016a5022e5ceac7c0a8784e1901542
Author: egorklimov <kl...@...>
Date: 2018-07-18T16:19:37Z
ZeppelinConfiguration property zeppelin.notebook.s3.timeout added
commit 0c98216100fb580b4d874b8eb53bb8fec949a747
Author: egorklimov <kl...@...>
Date: 2018-07-18T16:28:09Z
Docs updated
commit 9770a4793cd7c8c7b6e20cde05bb924a986458f1
Author: egorklimov <kl...@...>
Date: 2018-07-18T16:32:56Z
zeppelin-site.xml.template updated
----
---
[GitHub] zeppelin pull request #3082: [ZEPPELIN-3636] Add timeout for s3 amazon bucke...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3082
---
[GitHub] zeppelin issue #3082: [ZEPPELIN-3636] Add timeout for s3 amazon bucket endpo...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3082
LGTM
---
[GitHub] zeppelin issue #3082: [ZEPPELIN-3636] Add timeout for s3 amazon bucket endpo...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3082
@jongyoul check my test please.
---