You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/30 14:31:02 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #9269:
[FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase
tillrohrmann commented on a change in pull request #9269: [FLINK-9900][tests] Fix unstable ZooKeeperHighAvailabilityITCase
URL: https://github.com/apache/flink/pull/9269#discussion_r308755028
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvailabilityITCase.java
##########
@@ -366,6 +369,11 @@ public void snapshotState(FunctionSnapshotContext context) throws Exception {
failInCheckpointLatch.await();
if (!failedAlready.getAndSet(true)) {
throw new RuntimeException("Failing on purpose.");
+ } else {
Review comment:
Instead of this else branch, couldn't we always fail unless `afterMessWithZooKeeper` is `true`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services