You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Subroto Sanyal (JIRA)" <ji...@apache.org> on 2012/05/23 13:36:41 UTC
[jira] [Created] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Subroto Sanyal created MAPREDUCE-4280:
-----------------------------------------
Summary: LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
Key: MAPREDUCE-4280
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 0.23.1
Reporter: Subroto Sanyal
I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Posted by "Subroto Sanyal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281539#comment-13281539 ]
Subroto Sanyal commented on MAPREDUCE-4280:
-------------------------------------------
{quote}
This is fixed in MR2's LocalJobRunner in 2.x and trunk via MAPREDUCE-3563. We probably have to backport it to 1.x.
{quote}
I feel even this fix doesn't honors the cleanupJob of CustomCommitter. Seems needs to be fixed in some 2.x as well.
> LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
> -------------------------------------------------------------
>
> Key: MAPREDUCE-4280
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Subroto Sanyal
>
> I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
> When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
> Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
> Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281544#comment-13281544 ]
Harsh J commented on MAPREDUCE-4280:
------------------------------------
Ok you've discovered a second, valid issue. Can we repurpose this JIRA to fix that, or would you like to see this backported to 1.x-based releases too? In the latter case, please file a second JIRA to fix and add a cleanup call.
> LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
> -------------------------------------------------------------
>
> Key: MAPREDUCE-4280
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Subroto Sanyal
>
> I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
> When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
> Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
> Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281532#comment-13281532 ]
Harsh J commented on MAPREDUCE-4280:
------------------------------------
This is fixed in MR2's LocalJobRunner in 2.x and trunk via MAPREDUCE-3563. We probably have to backport it to 1.x.
> LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
> -------------------------------------------------------------
>
> Key: MAPREDUCE-4280
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.1
> Reporter: Subroto Sanyal
>
> I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
> When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
> Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
> Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Posted by "Subroto Sanyal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281548#comment-13281548 ]
Subroto Sanyal commented on MAPREDUCE-4280:
-------------------------------------------
I feel the current JIRA description targets the "second, valid issue":-).
I think no need to re-purpose the JIRA (may be we need to change the Affects Version).
{quote} would you like to see this backported to 1.x-based releases too?{quote}
Raised a new one MAPREDUCE-4281
> LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
> -------------------------------------------------------------
>
> Key: MAPREDUCE-4280
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Subroto Sanyal
>
> I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
> When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
> Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
> Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4280) LocalJobRunner doesn't honor
custom OutputCommiter cleanupJob
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4280:
-------------------------------
Target Version/s: 1.1.0
Affects Version/s: (was: 0.23.1)
1.0.0
Changing affected versions.
> LocalJobRunner doesn't honor custom OutputCommiter cleanupJob
> -------------------------------------------------------------
>
> Key: MAPREDUCE-4280
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4280
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Subroto Sanyal
>
> I have an implementation SampleFileOutputCommiter which extends org.apache.hadoop.mapred.FileOutputCommitter . The implementation has specific code to be executed during cleanupJob() execution.
> When the framework(LocalJobRunner) makes a call to commitJob(), the framework never takes care of calling the cleanupJob() instead it calls org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter commitJob() which internally calls its own cleanupJob().
> Though the method cleanupJob is deprecated but, still I feel the framework should take care of executing it as it is being executed from org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter.
> Currently the framework is not letting the Jobs written with MRV1 to run properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira